Make nologo switch accept boolean values to enable explicit logo display control #12541
Conversation
nologo switch a bool, which is false when unspecified, true when specified with no value (as it is today), but able to accept -nologo:false and display the logo.
| new ParameterizedSwitchInfo( ["featureAvailability", "fa"], ParameterizedSwitch.FeatureAvailability, null, true, "MissingFeatureAvailabilityError", true, false, "HelpMessage_46_FeatureAvailabilitySwitch"), | ||
| new ParameterizedSwitchInfo( ["multithreaded", "mt"], ParameterizedSwitch.MultiThreaded, null, false, null, true, false, "HelpMessage_49_MultiThreadedSwitch") | ||
| new ParameterizedSwitchInfo( ["multithreaded", "mt"], ParameterizedSwitch.MultiThreaded, null, false, null, true, false, "HelpMessage_49_MultiThreadedSwitch"), | ||
| new ParameterizedSwitchInfo( ["nologo"], ParameterizedSwitch.NoLogo, null, false, null, true, false, "HelpMessage_5_NoLogoSwitch") |
There was a problem hiding this comment.
@copilot update HelpMessage_5_NoLogoSwitch to mention that you can also pass -nologo:false
There was a problem hiding this comment.
Updated the help message to document the boolean parameter support. The help text now shows -noLogo[:true|false] and explicitly mentions that users can specify -nologo:false to show the logo. (c3b9b87)
|
@copilot fix the failing test |
Fixed the failing test by updating the expected command line switch order. Since nologo moved from parameterless to parameterized, it now appears alphabetically with other parameterized switches rather than first. Updated test expectations accordingly. (53e44d8) |
There was a problem hiding this comment.
Pull Request Overview
This PR enhances the nologo MSBuild command-line switch to accept boolean parameters, enabling explicit control over logo display. Previously, nologo was a parameterless switch that could only suppress the logo. Now it supports -nologo:false to explicitly show the logo and -nologo:true (equivalent to -nologo) to suppress it.
Key changes:
- Migrated
nologofrom parameterless to parameterized switch architecture - Added boolean parameter processing with proper error handling for invalid values
- Updated help documentation to reflect new syntax options
Reviewed Changes
Copilot reviewed 18 out of 18 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/MSBuild/XMake.cs | Updated logo processing logic to handle parameterized boolean nologo switch |
| src/MSBuild/CommandLineSwitches.cs | Moved nologo from parameterless to parameterized switch enumeration |
| src/MSBuild/Resources/Strings.resx | Added error message for invalid nologo values and updated help text |
| src/MSBuild/Resources/xlf/*.xlf | Updated localization files with new help text and error message |
| src/MSBuild.UnitTests/CommandLineSwitches_Tests.cs | Updated and added tests for new boolean nologo behavior |
| src/Build.UnitTests/BinaryLogger_Tests.cs | Fixed test expectations to account for switch ordering changes |
Co-authored-by: rainersigwald <[email protected]>
Co-authored-by: rainersigwald <[email protected]>
… adjust for nologo switch order Co-authored-by: rainersigwald <[email protected]>
baronfel
force-pushed
the
copilot/fix-2f2cf703-df11-47a1-9338-7f3c635a181e
branch
from
f8027ed to
47239a0
Compare
Implementation Plan: Make
nologoswitch a boolean parameterAnalysis Complete:
nologobehavior (parameterless switch)Implementation Complete:
nologofromParameterlessSwitchtoParameterizedSwitchinCommandLineSwitches.csnologoentry to parameterized switches map with boolean supportnologoas a boolean switch usingProcessBooleanSwitch-nologo:falsefunctionality-nologo) defaults totrue-nologo:falsedisplays the logo-nologo:truehides the logo (same as-nologo)false(show logo by default)Files Modified:
src/MSBuild/CommandLineSwitches.cs- Moved nologo to parameterized switchessrc/MSBuild/XMake.cs- Updated processing logic for boolean nologosrc/MSBuild/Resources/Strings.resx- Added InvalidNoLogoValue error message and updated help textsrc/MSBuild.UnitTests/CommandLineSwitches_Tests.cs- Updated and added testssrc/Build.UnitTests/BinaryLogger_Tests.cs- Fixed test expectation for switch orderManual Testing Results:
-nologo: Hides logo-nologo:true: Hides logo-nologo:false: Shows logo-nologo:invalid: Shows MSB1071 error-noLogo[:true|false]syntaxTest Fix Details:
Fixed the failing
BinaryLoggerTests.SuppressCommandOutputForNonDiagVerbositytest by updating the expected command line order. Sincenologomoved from parameterless to parameterized, it now appears in alphabetical order with other parameterized switches:Before:
-nologo -bl:... -verbosity:diagAfter:
-bl:... -nologo -verbosity:diagThe implementation is complete and all tests are passing.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.